Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bump jasmine to 4.x to get ArrayBuffer equality matchers #2068

Merged
merged 1 commit into from
Jul 19, 2022
Merged

test: bump jasmine to 4.x to get ArrayBuffer equality matchers #2068

merged 1 commit into from
Jul 19, 2022

Conversation

fippo
Copy link
Member

@fippo fippo commented Jul 14, 2022

No description provided.

@fippo fippo marked this pull request as ready for review July 14, 2022 14:37
@fippo
Copy link
Member Author

fippo commented Jul 14, 2022

needed for #2067

saghul
saghul previously requested changes Jul 14, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@NewEraCracker
Copy link
Contributor

Hello, while you are at it. Probably a good idea to update the following related packages - I have tested the following versions:

    "karma": "6.3.20",
    "karma-chrome-launcher": "3.1.1",
    "karma-jasmine": "5.0.1",
    "karma-sourcemap-loader": "0.3.8",

My two cents.

@NewEraCracker
Copy link
Contributor

NewEraCracker commented Jul 14, 2022 •
edited
Loading

See #2069 about tests fail.

Last versions I had working on my system were:

    "jasmine-core": "4.1.1",
    "karma": "6.3.20",
    "karma-chrome-launcher": "3.1.1",
    "karma-jasmine": "5.0.1",
    "karma-sourcemap-loader": "0.3.8",
    "karma-webpack": "5.0.0",

Now going with - just checked which were latest - and the workaround at #2069:

    "jasmine-core": "4.2.0",
    "karma": "6.4.0",
    "karma-chrome-launcher": "3.1.1",
    "karma-jasmine": "5.1.0",
    "karma-sourcemap-loader": "0.3.8",
    "karma-webpack": "5.0.0",

@fippo
Copy link
Member Author

fippo commented Jul 14, 2022

leaving karma-jasmine at 4.x for now

@NewEraCracker NewEraCracker mentioned this pull request Jul 14, 2022
Closed
@nils-ohlmeier nils-ohlmeier dismissed saghul’s stale review July 19, 2022 16:55

This has been addressed in one of the later commits

@nils-ohlmeier nils-ohlmeier merged commit cf01fc0 into master Jul 19, 2022
@nils-ohlmeier nils-ohlmeier deleted the bump-jasmine branch July 19, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-ohlmeier nils-ohlmeier nils-ohlmeier approved these changes

@saghul saghul saghul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fippo @NewEraCracker @saghul @nils-ohlmeier