fix: Do not use generator expression for "/utf-8" on Windows

See: facebook#2250 Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan · Aug 12, 2024 · 7e336ba · 7e336ba
1 parent c5aa5c4
commit 7e336ba
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/CMake/GenPkgConfig.cmake b/CMake/GenPkgConfig.cmake
@@ -105,6 +105,14 @@ function(gen_pkgconfig_vars)
  )
  endif()
 
+ # On Windows replace "$<$<COMPILE_LANGUAGE:CXX>:/utf-8>" with "/utf-8"
+ # See: https:/facebook/folly/issues/1433
+ if(WIN32)
+ string(REPLACE
+ "$<$<COMPILE_LANGUAGE:CXX>:/utf-8>" "/utf-8"
+ cflags "${cflags}"
+ )
+
  set("${var_prefix}_CFLAGS" "${cflags}" PARENT_SCOPE)
  set("${var_prefix}_PRIVATE_LIBS" "${private_libs}" PARENT_SCOPE)
 endfunction()