Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional options for autops #108

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Conversation

kaustubhmote
Copy link
Collaborator

This PR does 3 things to the autops function:

  1. Allows an optional return_phases argument. If set to True, the optimized phases will be returned. By default, this is set to False.
  2. Allows additional (optional) keyword arguments to be passed to the scipy.optimize.fmin. The default options work fine most of the time for autops, but this way, one has the option to turn off the (sometimes irritating) convergence messages (using disp=False). Also maxiter and ftol might be useful in some cases. The complete list of options is documented here.
  3. "Normalizes" the return value of the "acme" function to a reasonable number. The current return value is very high and sometimes causes convergence issues. This should fix Problem with proc_autophase.autops(data, "acme") #102.

None of the above should change the default behavior of the autops function and all changes are backward compatible. This PR has some overlap with #48, but that seems to have stalled, and I am not implementing any of the changes proposed to the "acme" function itself.

@jjhelmus
Copy link
Owner

LGTM.

@jjhelmus jjhelmus merged commit f3aed10 into jjhelmus:master Jul 30, 2019
@kaustubhmote kaustubhmote deleted the autops branch March 28, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with proc_autophase.autops(data, "acme")
2 participants