Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v4.0.1 tag? #113

Closed
arBalasquide opened this issue Jan 2, 2024 · 3 comments
Closed

Create v4.0.1 tag? #113

arBalasquide opened this issue Jan 2, 2024 · 3 comments

Comments

@arBalasquide
Copy link

v4.0.0 has a typo in the CMake, which was fixed in a later commit, that caused some includes to be missing on an install. Would be nice to bump the release so others don't go to v4.0.0 and waste time figuring out why their build isn't working.

Thanks!

@jkriege2
Copy link
Owner

jkriege2 commented Jan 3, 2024

Do you remember which fixes are neccesarry?
Otherwise I'm hoping to make a new 5.0.0 release soon!

@arBalasquide
Copy link
Author

Yes, it was a typo

install(FILES ${HEADERS}

It should be HEADERS_BASE. Already fixed in a later commit, but causes build issues in the 4.0.0 release. If a new release is coming soon anyhow, then its no big deal.

jkriege2 added a commit that referenced this issue Jan 3, 2024
@jkriege2
Copy link
Owner

jkriege2 commented Jan 3, 2024

https:/jkriege2/JKQtPlotter/releases/tag/v4.0.1 should fix the bug!

@jkriege2 jkriege2 closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants