Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fangraphs month enum to support 'last x' games #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abrobert
Copy link

@abrobert abrobert commented Jun 9, 2023

Fangraphs allows filtering leaderboards by last seven, fourteen and thirty days by setting the month to 1, 2, or 3 respectively.

  • Adds support to pybaseball to filter by these values from fangraphs

Copy link

@markspotsthex markspotsthex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Fangraphs URL would result in the appropriate time period with this change to the ENUMS.

This pull request is not blocked by #367, which appears to only affect when month is specified for in-season months (March-October).

@abroberts14
Copy link

Any update on this? @markspotsthex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants