Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Lahman Database Scraping #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmaslek
Copy link

@jmaslek jmaslek commented Jun 18, 2024

This PR redirects the Lahman database from a 404 github link to the dropbox site that is found on baseball1.com.

In order to extract the data, py7zr was added to the requirements.

@schorrm
Copy link
Collaborator

schorrm commented Jun 19, 2024

couldl this be addressed by moving the link to soemthing in https:/chadwickbureau/retrosheet?

@jmaslek
Copy link
Author

jmaslek commented Jun 19, 2024

couldl this be addressed by moving the link to soemthing in https:/chadwickbureau/retrosheet?

Looks like there may be some overlapping files, but nothing that mimics Lahman's db.

@bdilday
Copy link
Contributor

bdilday commented Jun 19, 2024

what do y'all think about extracting the data and posting it to a repo in github? maybe even embedded in pybaseball?

@jmaslek
Copy link
Author

jmaslek commented Jun 19, 2024

what do y'all think about extracting the data and posting it to a repo in github? maybe even embedded in pybaseball?

I have no issue with that (I assume theres no licensing issues with that). I'm happy to add a folder here or put them on my own github.

@blue-shoes
Copy link

As of today, the Lahman DB has been donated to the Society for American Baseball Research (SABR). SABR is now responsible for hosting and maintaining the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants