Update HeaderSelector when configuration changes #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a new HeaderSelector instance with updated configuration
|
Thanks for the catch! I never tested the Laravel library with a non-NA endpoint...whoops. |
jlevers
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the multi version of the laravel library. Whenever a seller region was not NA, I got a "403 forbidden". Tracking it down, I noticed, that the laravel lib initially loads the "HeaderSelector" with the default config.
When you call an APIs (or
BaseAPIs)setConfigmethod, the new configuration applies, including the new region. But, as the HeaderSelector still references the 'old' config with region NA, a wrong 'Host' header will be set. Therefore the request signing process is wrong and ends in a 403, whenever the region is not NA.