Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow setting custom NTP servers #29

Closed
TheGroundZero opened this issue May 31, 2023 · 4 comments · Fixed by #31
Closed

Feature Request: Allow setting custom NTP servers #29

TheGroundZero opened this issue May 31, 2023 · 4 comments · Fixed by #31

Comments

@TheGroundZero
Copy link
Contributor

I prefer to keep IoT devices on a non-internet VLAN where possible.
I also run my own NTP server on the local network and communicate its address via DHCP to clients.

It would be nice to be able to configure my own NTP server either in the Settings page or have the device follow the DHCP options for NTP servers.

@TheGroundZero
Copy link
Contributor Author

I'm working on this in a fork, but I'm not used to working with ArduinoIDE.
So I'm looking to incorporate this: https:/ropg/ezTime#setserver-and-setinterval

@TheGroundZero
Copy link
Contributor Author

Can anyone try to compile this and check if it works?
https:/TheGroundZero/clockwise/commit/8a1e3f3c9b47f95e3bde1d3aa69961591d40ffe9

@jnthas
Copy link
Owner

jnthas commented Jun 3, 2023

@TheGroundZero it was a great first attempt. It almost work at first. I made some changes in your fork I would like to push the changes, I think you have to PR first

@TheGroundZero
Copy link
Contributor Author

@jnthas I've initiated the PR and marked it as editable by the maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants