Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made SSL connections use the system certificate store by default. #226

Merged
merged 1 commit into from
Aug 3, 2013
Merged

Made SSL connections use the system certificate store by default. #226

merged 1 commit into from
Aug 3, 2013

Conversation

nchelluri
Copy link
Contributor

  • Set http.verify_mode to OpenSSL::SSL::VERIFY_PEER by default
  • Use OpenSSL::X509::Store.new as certificate store unless another is specified

Adapted from Faraday.
See: https:/lostisland/faraday/blob/b25adc0ca6b47eb5150494a735721579862990f0/lib/faraday/adapter/net_http.rb#L100

- Set http.verify_mode to OpenSSL::SSL::VERIFY_PEER by default
- Use OpenSSL::X509::Store.new as certificate store unless another is specified

Adapted from Faraday.
See: https:/lostisland/faraday/blob/b25adc0ca6b47eb5150494a735721579862990f0/lib/faraday/adapter/net_http.rb#L100
jnunemaker pushed a commit that referenced this pull request Aug 3, 2013
Made SSL connections use the system certificate store by default.
@jnunemaker jnunemaker merged commit ad4d3ab into jnunemaker:master Aug 3, 2013
@nchelluri nchelluri deleted the ssl-defaults-to-system-cert-store branch August 4, 2013 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants