Added read_timeout and open_timeout options #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2014 11:00
…dually, overriding the timeout option if set
|
Looks fine. My only issue is the tabs/formatting being inconsistent with the rest of the project. I'll pull and change that when I get time, but I would definitely pull this faster if you could fix that up yourself. Thanks for the contribution! |
|
Tabs are now spaces. Thanks for considering and for the great library! |
jnunemaker
pushed a commit
that referenced
this pull request
Mar 13, 2014
Added read_timeout and open_timeout options
|
👍 when will this feature release to new version? Need this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to set the open_timeout only to ensure that services were available but if they were long running, I wanted to wait for reads. I determined that the open/read timeouts should override the general timeout setting if it was set.