Fix #713 #714
Merged
Fix #713 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the issue(s) described in jnunemaker#713. To fix the logger option issue, I simply delete `Request.options[:logger]` when dumping. To fix the proc parser issue, I delete `Request.options[:parser]` if and only if `Request.options[:logger]` is a proc. If `Request.options[:logger]` is a regular class, `Marshal.dump` should proceed as normal. This should not affect the `Marshal.dump` behavior described in issue jnunemaker#143 and fixed by PR jnunemaker#618. I have added a feature spec to make sure marshalling the request works as intended, as well as a unit test to ensure `Marshal.load(Marshal.dump(req))` works as it should.
|
@baberthal thanks! This looks good to me. @TheSmartnik any thoughts since you worked on #618? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue(s) described in #713. To fix the logger option
issue, I simply delete
Request.options[:logger]when dumping. To fixthe proc parser issue, I delete
Request.options[:parser]if and onlyif
Request.options[:logger]is a proc. IfRequest.options[:logger]is a regular class,
Marshal.dumpshould proceed as normal. This shouldnot affect the
Marshal.dumpbehavior described in issue #143 and fixedby PR #618.
I have added a feature spec to make sure marshalling the request
works as intended, as well as a unit test to ensure
Marshal.load(Marshal.dump(req))works as it should.I would love to hear your feedback on this. I'm not crazy about simply deleting the
:loggerand:parseroptions, but I'm not sure how else to handle it. Thanks in advance.