-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixyll.gemspec #334
Add pixyll.gemspec #334
Conversation
Here are the contents of the gem at this point:
|
The site navigation changes were separated and moved to #342 |
README.md
Outdated
Then, add this line to your Jekyll site: | ||
|
||
```yaml | ||
theme: minima |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be pixyll
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry. Good catch. Fixed.
This is awesome! |
d95cf7f
to
c0f7d06
Compare
# A simple Ruby Gem to bootstrap dependencies for setting up and | ||
# maintaining a local Jekyll environment in sync with GitHub Pages | ||
# https:/github/pages-gem | ||
gemspec | ||
gem 'github-pages' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving this to gemspec file as an runtime dependency if it's needed. That is in the Rubygem's doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find it was necessary to add github-pages as a runtime dependency. I also felt it wasn't necessary. Github-pages brings in a lot of unnecessary gems as dependencies, including other themes. See the list of dependencies on it's gem page:
https://rubygems.org/gems/github-pages
Pixyll is such a minimal theme, that it seemed like overkill bringing in all these dependencies.
However, if you find there are dependencies from github-pages gem that should be included for Pixll, then let me know.
I still keep the github-pages gem in the Gemfile only to maintain Pixyll's official site on GitHub, and for people who want to continue to use pixyll as a fork, rather than as a jekyll theme/gem.
This is a good question, and I meant to explain this.
Hey @ashawley, I don't have the time right now to look into the gem implementation, but I've just invited you to become a contributor on the repo. I trust you to get the gem working without breaking backwards compatibility. If/when you publish to ruby gems, though, please also add me as an owner. |
I've discovered we'll need to consider some breaking changes to support the gem format:
To avoid breaking compatability, maybe introduce the gem in a new major version? 3.0? Maybe keep developing 2.x series as I tried the theme externally from the repo, reviewed the served site more carefully and noticed other issues. For example, there are references in Anyway, still some more work needed on this. The good news is it would be not a problem to add you as an owner of the gem: |
ae3b009
to
408c128
Compare
Any progress? |
0bdf3b3
to
de2af26
Compare
Scorching the earth and starting over in a new PR. Please, stand by... |
See #333 for the consequences of making a Gem.
I'm suggesting the first version of the Gem will be 2.9.0, since the last release tag in git is 2.8.0.
According to my analysis of building the site with master and this PR, the only change is where the CSS file is located:
ashawley/pixyll-site@master...gemspec
The rest of the changes are whitespace-only changes.