Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in Appveyor #375

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Build in Appveyor #375

merged 1 commit into from
Jan 28, 2019

Conversation

ashawley
Copy link
Collaborator

@ashawley ashawley commented Dec 9, 2018

Automated builds specifically on Windows may benefit those users. Although, I predict it isn't necessary: The entire stack (Ruby, bundler, Jekyll) should be so portable these days that it is of no concern.

However, maybe there's a chance this is generally useful as a starting point to some users. Appveyor would be the recommendation. And a Windows build may be helpful should we run in to issues specific to Windows users with gem-based themes for #333 and #360.

Before merging this, @johno would need to sign-in at Appveyor and enable this repo.

@ashawley
Copy link
Collaborator Author

ashawley commented Dec 9, 2018

I've enabled it for my fork, and it works well:
https://ci.appveyor.com/project/ashawley/pixyll/builds/20880547

@johno
Copy link
Owner

johno commented Dec 9, 2018

Awesome! I’ll put it on my todo list for this week.

@ashawley
Copy link
Collaborator Author

@johno Could you try enabling Appveyor for Pixyll, at some point? Start here: https://ci.appveyor.com/login If it works, then merge this branch.

@johno
Copy link
Owner

johno commented Jan 28, 2019

Done, thanks @ashawley

@johno johno merged commit 64c1843 into johno:master Jan 28, 2019
@ashawley
Copy link
Collaborator Author

Cool, thanks! Did you see a build happen?

I was expecting Appveyor would be running for pull requests or merges to master. I'm looking here, https://ci.appveyor.com/project/johno/pixyll, but not seeing anything.

@johno
Copy link
Owner

johno commented Jan 28, 2019

Oh whoops, looks like I didn't fully add it. Should be g2g now https://ci.appveyor.com/project/johno/pixyll

@ashawley ashawley deleted the appveyor branch January 28, 2019 16:14
@ashawley
Copy link
Collaborator Author

🚀 Looking good! Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants