Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underline active link in nav #383

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Underline active link in nav #383

merged 1 commit into from
Jan 28, 2019

Conversation

ashawley
Copy link
Collaborator

Fixes #367.

johno
johno approved these changes Jan 17, 2019
View reviewed changes
Copy link
Owner

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏇

@ashawley
Copy link
Collaborator Author

Here's a preview:

https://ashawley.github.io/pixyll/about/

@ashawley
Underline active link in nav
d196f09 
When visiting the a page in the navigation header, show a light
gray bottom border to communicate it is the current page.
@ashawley ashawley merged commit 3e2207a into johno:master Jan 28, 2019
@ashawley ashawley deleted the nav-active-link branch January 28, 2019 16:30
@ashawley ashawley mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashawley @johno