Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update various links #435

Merged
merged 3 commits into from
Apr 18, 2021
Merged

Update various links #435

merged 3 commits into from
Apr 18, 2021

Conversation

atouchet
Copy link
Contributor

No description provided.

@ashawley
Copy link
Collaborator

Thanks for all these fixes!

@ashawley
Copy link
Collaborator

There's a very strange error on the Travis build:

$ grep johno/pixyll    _site/css/pixyll.css
grep: _site/css/pixyll.css: No such file or directory
The command "grep johno/pixyll    _site/css/pixyll.css" exited with 2.

ashawley
ashawley reviewed Apr 18, 2021
View reviewed changes
_config.yml Outdated
@@ -4,7 +4,7 @@ email: [email protected]
author: John Otander
description: "A simple, beautiful theme for Jekyll that emphasizes content rather than aesthetic fluff."
baseurl: ""
url: "http://pixyll.com"
url: "https://pixyll.com/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Jekyll is expecting the trailing slash. The https is fine.

@ashawley
Copy link
Collaborator

There's a very strange error on the Travis build:

I though this was a spurious error, but I can reproduce locally when I check out the branch:

$ grep johnotander/pixyll _site/css/pixyll.css
grep: _site/css/pixyll.css: No such file or directory

fwiw I haven't run bundle, so it's not from a gem update.

ashawley
ashawley reviewed Apr 18, 2021
View reviewed changes
_sass/_base.scss Outdated
@@ -1,15 +1,15 @@
@charset "UTF-8";
@charset "UTF-8";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm staring at this, but I'm not sure what the change is on this line. Maybe it's responsible for the broken build?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at git diff in the console it seems it's <U+FEFF>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened there. Thanks for taking care of it.

ashawley
ashawley reviewed Apr 18, 2021
View reviewed changes
css/pixyll.scss Outdated
@@ -1,13 +1,13 @@
---
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue repeats itself here.

@ashawley ashawley merged commit f6c8518 into johno:master Apr 18, 2021
@atouchet atouchet deleted the url branch April 19, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashawley ashawley ashawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atouchet @ashawley