Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented late analog / digital transition #2778

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

rainman110
Copy link
Contributor

This PR implements a new analog / digital sync algorithm.

It mostly implements the case, when the last digit transitions late (e.g. after the analog value has passed zero).

Note: there are two tests failing, in particular

    digits = { 1.1, 9.0, 4.0};
    analogs = { 9.1, 2.6, 6.25, 9.7};
    expected = "194.9259";

(Returns 193.9259)

Here, the accumulated post-comma value is 9.26, which is larger than 9.2 - the transition has already passed. To fix this, we could evaluate only the first analog value instead. To be discussed...

The second test failing is:

      digits = { 1.0, 4.0, 2.0};  // 141.9269 als falsches Ergebnis
      analogs = { 9.2, 2.5, 6.8, 9.0};
      expected = "142.9269";

(Returns 141.9269)

In this case, the transition value is 9.2. According to my interpretation, the 9.2 is incorrectly set, as the transition has not yet started for this test case. To be discussed...

Fixes #2743

Complete rewrite of analog / digital transition

Two tests is still failing, which need to be discussed.
@jomjol jomjol merged commit b5a4cfe into jomjol:rolling Dec 31, 2023
6 checks passed
caco3 added a commit that referenced this pull request Feb 2, 2024
* update

* Revert "v15.4.0"

This reverts commit 74d4f20.

* Revert "prepare v15.4.0 versuch 2"

This reverts commit e790a14.

* revert submnodules (#2768)

Co-authored-by: CaCO3 <[email protected]>

* Update submodules (#2769)

- Update `esp-nn` to v1.0.2
- Update `esp32-camera` to v2.0.6
- Updated `tflite-micro-esp-examples` (The repo got renamed to `esp-tflite-micro ` and the folder structure got cleaned up).

* fix(unity-test): Run unity tests in dedicated task
Avoid running out of heap

* Add delay

* Update

* Update

* Enhance busy notification (#2774)

* on marker updating, show message and retry until round got completed

* same for contrast enhancement

---------

Co-authored-by: CaCO3 <[email protected]>

* Fix negatives on extended resolution false #2744 (#2772)

* not extended resolution allows -1 on the lowest digit

* not extended resolution allows -1 on the lowest number

* negatives on last value digit with -1 will set to prevalue and is not an error  #2744

---------

Co-authored-by: jomjol <[email protected]>

* Implemented late analog / digital transition (#2778)

* Implemented late transition

Complete rewrite of analog / digital transition

Two tests is still failing, which need to be discussed.

* Allow wider range of transition values to support late transition

* Added documentation

* Fix testings (#2783)

* fix all tests and more description

* The decimal point offset. -3 corresponds to x.yyy

---------

Co-authored-by: jomjol <[email protected]>

* Bugfix InfluxDB shifting times (#2785)

* Modify time_sntp

* Update time_sntp.cpp

* Update time_sntp.cpp

* update

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update time_sntp.cpp

* Upload

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Remove Time Convert vom influx Interface

* Update platform-espressif32 to 6.5.0 (#2770)

* Update ESP IDF to 6.5.0

* Migration to new IDF

* Correct smtp vor v5.1

---------

Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: jomjol <[email protected]>

* ATA-Trim support (#2781)

* Add files via upload

* Update main.cpp

* Update main.cpp

* Update main.cpp

* Update Helper.cpp

* Update Helper.h

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update diskio_sdmmc_mh.c

* Update diskio_sdmmc_mh.h

* Update ff_mh.c

* Update vfs_fat_sdmmc_mh.c

* Update sdmmc_common_mh.h

* Update sdmmc_common_mh.c

* Update Helper.cpp

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update ff_mh.c

---------

Co-authored-by: CaCO3 <[email protected]>

* Update Changelog.md

* Add device info info page (#2789)

Signed-off-by: Florian Grabmeier <[email protected]>

* fix chip information REST API

* Update pipelines to fix warnings (#2841)

Update actions

* Move param doc (#2843)

moved param doc from docs repo to here

* fix(tflite): Fix memory leaks in tflite integration (#2842)

* Update Changelog.md (#2849)

---------

Signed-off-by: Florian Grabmeier <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: Martin Siggel <[email protected]>
Co-authored-by: michael <[email protected]>
Co-authored-by: flox_x <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
@caco3 caco3 mentioned this pull request Feb 2, 2024
caco3 added a commit that referenced this pull request Feb 2, 2024
* update

* Revert "v15.4.0"

This reverts commit 74d4f20.

* Revert "prepare v15.4.0 versuch 2"

This reverts commit e790a14.

* revert submnodules (#2768)



* Update submodules (#2769)

- Update `esp-nn` to v1.0.2
- Update `esp32-camera` to v2.0.6
- Updated `tflite-micro-esp-examples` (The repo got renamed to `esp-tflite-micro ` and the folder structure got cleaned up).

* fix(unity-test): Run unity tests in dedicated task
Avoid running out of heap

* Add delay

* Update

* Update

* Enhance busy notification (#2774)

* on marker updating, show message and retry until round got completed

* same for contrast enhancement

---------



* Fix negatives on extended resolution false #2744 (#2772)

* not extended resolution allows -1 on the lowest digit

* not extended resolution allows -1 on the lowest number

* negatives on last value digit with -1 will set to prevalue and is not an error  #2744

---------



* Implemented late analog / digital transition (#2778)

* Implemented late transition

Complete rewrite of analog / digital transition

Two tests is still failing, which need to be discussed.

* Allow wider range of transition values to support late transition

* Added documentation

* Fix testings (#2783)

* fix all tests and more description

* The decimal point offset. -3 corresponds to x.yyy

---------



* Bugfix InfluxDB shifting times (#2785)

* Modify time_sntp

* Update time_sntp.cpp

* Update time_sntp.cpp

* update

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update time_sntp.cpp

* Upload

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Remove Time Convert vom influx Interface

* Update platform-espressif32 to 6.5.0 (#2770)

* Update ESP IDF to 6.5.0

* Migration to new IDF

* Correct smtp vor v5.1

---------




* ATA-Trim support (#2781)

* Add files via upload

* Update main.cpp

* Update main.cpp

* Update main.cpp

* Update Helper.cpp

* Update Helper.h

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update diskio_sdmmc_mh.c

* Update diskio_sdmmc_mh.h

* Update ff_mh.c

* Update vfs_fat_sdmmc_mh.c

* Update sdmmc_common_mh.h

* Update sdmmc_common_mh.c

* Update Helper.cpp

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update ff_mh.c

---------



* Update Changelog.md

* Add device info info page (#2789)



* fix chip information REST API

* Update pipelines to fix warnings (#2841)

Update actions

* Move param doc (#2843)

moved param doc from docs repo to here

* fix(tflite): Fix memory leaks in tflite integration (#2842)

* Update Changelog.md (#2849)

---------

Signed-off-by: Florian Grabmeier <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: Martin Siggel <[email protected]>
Co-authored-by: michael <[email protected]>
Co-authored-by: flox_x <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
@Slider0007 Slider0007 mentioned this pull request Feb 3, 2024
@gec75
Copy link

gec75 commented Feb 9, 2024

I have the same problem described in #2857, worked correctly before.
This discussion is only about early transition, late transition is ignored??
#issuecomment-1935514362

digits = { 2.0, 5.0, 1.9};
analogs = { 0.8, 8.8, 9.9, 0.1};
expected = "252.090";
wrong result: 251.090!!

caco3 added a commit that referenced this pull request Feb 12, 2024
caco3 added a commit that referenced this pull request Feb 12, 2024
haverland added a commit to haverland/AI-on-the-edge-device that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow even earlier analog to digital transition (AnalogDigitalTransitionStart < 6.0)
3 participants