Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support adjust padding bottom for branding image #709

Merged
merged 15 commits into from
Jul 7, 2024
Merged

feat: support adjust padding bottom for branding image #709

merged 15 commits into from
Jul 7, 2024

Conversation

Lzyct
Copy link
Contributor

@Lzyct Lzyct commented Jun 23, 2024

What it does

How to test

  1. follow this documentation to run and generate the native splash screen
  2. enable branding image
  3. add this config on your config yaml
   branding_bottom_padding: 24

  #branding_bottom_padding_ios: 24 #specific config for iOS
  #branding_bottom_padding_android: 24 #specific config for Android
  1. observe the branding image position

Screenshot

BEFORE

iPhone 15 Pro Max

image

iPhone SE

image

< Android 13

image

AFTER

iPhone 15 Pro Max

image

iPhone SE

image

< Android 13

image

Lzyct added 14 commits June 20, 2024 22:09
@Lzyct
fix: add space 24 for image branding
c4af3a5
@Lzyct
Merge pull request #1 from Lzyct/fix/safe-area-branding-ios
f2d9ccf 
fix: add space on bottom for image branding iOS
@Lzyct
fix: add space 24 for image branding android
9e500ec
@Lzyct
Merge pull request #2 from Lzyct/fix/safe-area-branding-android
4b33b61 
fix: add space 24 for image branding android
@Lzyct
feat: support adjust branding bottom padding for iOS
ca94510
@Lzyct
feat: support adjust branding bottom padding for iOS
017bc1d
@Lzyct
fix: resolve when receive data branding bottomPadding
7126c1a
@Lzyct
fix: resolve when receive data branding bottomPadding
bcf2450
@Lzyct
fix: resolve when receive data branding bottomPadding
fac9e58
@Lzyct
feat: support adjust branding bottom padding for Android
b271c48
@Lzyct
chore: update log for iOS
7d0debf
@Lzyct
fix: resolve when receive data branding bottomPadding
f11896d
@Lzyct
docs: update README.md to support adjust branding bottom padding
d8f6eeb
@Lzyct
Merge pull request #3 from Lzyct/feat/support-adjust-padding-bottom-f…
1d57963 
…or-branding-image

feat: support adjust padding bottom for branding image
@Lzyct Lzyct mentioned this pull request Jun 23, 2024
Closed
jonbhanson
jonbhanson requested changes Jun 27, 2024
View reviewed changes
Copy link
Owner

@jonbhanson jonbhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution. Just fix the one small mistake and I can merge it in.

lib/android.dart Outdated
@@ -325,8 +331,11 @@ void _applyLaunchBackgroundXml({

if (showBranding && gravity != brandingGravityValue) {
//add branding when splash image and branding image are not at the same position
final androidRandingItemXml = _androidBrandingItemXml.replaceAll(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

androidRandingItemXml is spelled wrong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the typo.
Please check again @jonbhanson

Thanks

@Lzyct Lzyct requested a review from jonbhanson July 2, 2024 06:56
@jonbhanson jonbhanson merged commit e12dfde into jonbhanson:master Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbhanson jonbhanson Awaiting requested review from jonbhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lzyct @jonbhanson