4.0 Remove Credentials option for GitHub as it's been phased out. #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove option for Github Credentials authentication method.
As basic authentication no longer can be set, basic authentication should be removed.
Username and password for Github no longer able to be supplied in credentials, so can no longer be used by helper.
Modify string to remove credentials reference.
Update COM_PATCHTESTER_NO_CREDENTIALS to reference token not credentials.
particthistle
changed the title
|
@particthistle Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #319.
Summary of Changes
Joomla 4 patch tester:
Testing Instructions
Go to Options for Joomla Patch Tester
Click on the GitHub Authentication Tab
When applied, Credentials option will be unavailable.
Before
Credentials Option is available
After
Credentials Option is unavailable.
