Rebuilding RPMs fails due to incorrect buildroot on F41

[antheas]

When rebuilding an rpm from an rpm on F41, it fails with the following:

Setting attribute {:virtualenv_system_site_packages?=>nil, :level=>:debug, :file=>"fpm/command.rb", :line=>"354", :method=>"block (2 levels) in execute"}
Setting attribute {:virtualenv_find_links_urls=>nil, :level=>:debug, :file=>"fpm/command.rb", :line=>"354", :method=>"block (2 levels) in execute"}
Setting from flags: epoch= {:level=>:info, :file=>"fpm/command.rb", :line=>"414", :method=>"block in execute"}
Setting from flags: vendor= {:level=>:info, :file=>"fpm/command.rb", :line=>"414", :method=>"block in execute"}
Converting rpm to rpm {:level=>:info, :file=>"fpm/package.rb", :line=>"195", :method=>"convert"}
Cleaning up staging path {:path=>"/tmp/package-rpm-staging-30e7807184f08ef9573d38fceaebfd6966d76f2879315e51a8c510523fd7", :level=>:debug, :file=>"fpm/package.rb", :line=>"284", :method=>"cleanup_staging"}
Reading template {:path=>"/usr/local/share/gems/gems/fpm-1.15.1/templates/rpm.erb", :level=>:info, :file=>"fpm/package.rb", :line=>"333", :method=>"template"}
Running rpmbuild {:args=>["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/BUILD", "--define", "_topdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_sourcedir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_rpmdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/RPMS", "--define", "_tmppath /tmp", "/tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/SPECS/kmod-kvmfr-6.11.3-300.fc41.x86_64.spec"], :level=>:info, :file=>"fpm/package/rpm.rb", :line=>"568", :method=>"output"}
Running command {:args=>["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/BUILD", "--define", "_topdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_sourcedir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_rpmdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/RPMS", "--define", "_tmppath /tmp", "/tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/SPECS/kmod-kvmfr-6.11.3-300.fc41.x86_64.spec"], :level=>:debug, :file=>"fpm/util.rb", :line=>"138", :method=>"execmd"}
Process is running {:pid=>319, :level=>:debug, :file=>"fpm/util.rb", :line=>"147", :method=>"execmd"}
warning: Macro expanded in comment on line 24: %undefine __check_files {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
 {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
warning: %source_date_epoch_from_changelog is set, but %changelog has no entries to take a date from {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Executing(%mkbuilddir): /bin/sh -e /tmp/rpm-tmp.N6MH7X {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Executing(%prep): /bin/sh -e /tmp/rpm-tmp.EnUYjF {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Executing(%build): /bin/sh -e /tmp/rpm-tmp.YDVXXn {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Executing(%install): /bin/sh -e /tmp/rpm-tmp.IrRq3d {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Processing files: kmod-kvmfr-6.11.3-300.fc41.x86_64-0.0.git.24.a7102df3-1.fc41.x86_64 {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
 {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
error: File not found: /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/BUILD/kmod-kvmfr-6.11.3-300.fc41.x86_64-0.0.git.24.a7102df3-build/BUILDROOT/lib/modules/6.11.3-300.fc41.x86_64/extra/kvmfr/kvmfr.ko.xz {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
RPM build warnings: {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
    Macro expanded in comment on line 24: %undefine __check_files {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
 {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
 {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
RPM build errors: {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
    %source_date_epoch_from_changelog is set, but %changelog has no entries to take a date from {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
    File not found: /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/BUILD/kmod-kvmfr-6.11.3-300.fc41.x86_64-0.0.git.24.a7102df3-build/BUILDROOT/lib/modules/6.11.3-300.fc41.x86_64/extra/kvmfr/kvmfr.ko.xz {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"47", :method=>"block in pipe"}
Process failed: rpmbuild failed (exit code 1). Full command was:["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/BUILD", "--define", "_topdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_sourcedir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", "--define", "_rpmdir /tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/RPMS", "--define", "_tmppath /tmp", "/tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8/SPECS/kmod-kvmfr-6.11.3-300.fc41.x86_64.spec"] {:level=>:error, :file=>"fpm/command.rb", :line=>"521", :method=>"rescue in execute"}
plugin directory {:plugin=>"rpm", :pathtype=>:staging_path, :path=>"/tmp/package-rpm-staging-2dd28958c255e3489d3f6f28afd491e33a891eecda136050526ea6efab7b", :file=>"fpm/command.rb", :line=>"528", :method=>"each"}
plugin directory {:plugin=>"rpm", :pathtype=>:staging_path, :path=>"/tmp/package-rpm-staging-2dd28958c255e3489d3f6f28afd491e33a891eecda136050526ea6efab7b", :file=>"fpm/command.rb", :line=>"528", :method=>"each"}
plugin directory {:plugin=>"rpm", :pathtype=>:build_path, :path=>"/tmp/package-rpm-build-d6b034159fb7b1f85af19c562878dff7b6948bf4732683e066b0b108c5b8", :file=>"fpm/command.rb", :line=>"528", :method=>"each"}

It appears that in F41 the buildroot define does not work, and rpmbuild tries to use BUILD/pkgname/BUILDROOT and fails since the files are not there.

The following patch fixes it:

sed -i -e 's/args = \["rpmbuild", "-bb"\]/args = \["rpmbuild", "-bb", "--buildroot", "#{build_path}\/BUILD"\]/g' /usr/local/share/gems/gems/fpm-*/lib/fpm/package/rpm.rb

Essentially, adding the arg --buildroot to rpmbuild. That arg says it is deprecated however a quick search online finds no replacement... As to what happened to --define buildroot <root> I do not know.