Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new image size (i.e. mode) #1

Open
hamid-m opened this issue Mar 20, 2015 · 4 comments
Open

Adding new image size (i.e. mode) #1

hamid-m opened this issue Mar 20, 2015 · 4 comments
Labels

Comments

@hamid-m
Copy link

hamid-m commented Mar 20, 2015

The Point Grey Chameleon camera (CMLN-13S2M-CS) I am using supports a resolution of 1296 x 964. This size is not defined as one of the available modes. Instead, the largest listed available mode is 1280 x 960, which if selected, causes the example code (examples/save_image.py) to fail. However, lower resolution does work (640 x 480).

Can the code be extended to handle the 1296 x 964 (Y8) option? I noticed a key mapping between mode names and integers are used. I wasn't sure if adding an entry (and thus changing indices) would break other features. If you can give me some guidance I'd be happy to put in a pull request.

And thank you for the great library.

@hamid-m
Copy link
Author

hamid-m commented Mar 20, 2015

Ok - an update. The save_image.py example from this repository seems to work fine. I guess the issue I described is true for another copy of pydc1394 here. Honestly, I'm unsure which of these three is the official repository for pydc1394:

  1. https:/jordens/pydc1394 (right here - PyPi points here too)
  2. https:/imrehg/pydc1394
  3. https://launchpad.net/pydc1394

@jordens
Copy link
Owner

jordens commented Mar 20, 2015

This is open source. There is no official version ;)

Everything started on launchpad. Then I forked it because the API was a mess and I wanted to make non-backcompatible changes. https:/imrehg/pydc1394 is a copy of the old (5 years since the last change) original launchpad tree https://launchpad.net/pydc1394. https:/jordens/pydc1394 is the continuation of https://code.launchpad.net/~jordens/pydc1394/work which is my forked tree.

Yes. In general you can add your new mode to the code and I'd be glad to accept a patch.
Take a look at https:/jordens/pydc1394/blob/master/pydc1394/dc1394.py
and http://damien.douxchamps.net/ieee1394/libdc1394/api/types/ to see whether it is already there (it needs to get to libdc1394 first) and where and how to add it.

@jordens
Copy link
Owner

jordens commented Mar 20, 2015

On the other hand, what you probably want is Format7, see http://damien.douxchamps.net/ieee1394/libdc1394/api/format7/

@jordens
Copy link
Owner

jordens commented Feb 26, 2018

Is this resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants