Map insert_final_newline to insertFinalNewline
#8
Conversation
test.js
Outdated
| assert.deepStrictEqual( | ||
| editorconfigToPrettier({ insert_final_newline: "false" }), | ||
| {} | ||
| ); |
There was a problem hiding this comment.
Do you think we need this test at all? Not sure how realistic this scenario is...
There was a problem hiding this comment.
I wanted to test an invalid value (wrong type here). But it might be well unnecessary. :)
There was a problem hiding this comment.
I added a commit to remove the unecessary test scenarios.
There was a problem hiding this comment.
Oh, I see. I think that since this function expects an already-parsed editorconfig object, it's safe to assume that the values will be valid, so I don't want to worry about testing invalid values. Thanks for removing the extra tests.
I did that to be the less verbose possible. But suport parsing the "true" value as well seems good to me 👍 |
|
Makes sense to me, I'll go ahead and merge this, and likely release a new version as well. Will keep you posted 👍 |
josephfrazier
changed the title
insert_final_newline to insertFinalNewline
|
Just published v0.2.0, thanks again for the contribution! https://www.npmjs.com/package/editorconfig-to-prettier/v/0.2.0 |
|
awesome @josephfrazier thank you! |
Description
This PR proposes to read editorconfig's
insert_final_newlinewhen it is set tofalse.Motivation
I know this PR might sound odd. Because Prettier follows unix guideline regarding the final newline (Prettier doc reference).
Yet, handlebars / glimmer does not follow this standard (see reference here) because it would insert empty nodes at the bottom of the component's file.
So for now Prettier respects this handlebars choice and remove the final newline. But this is somehow inconsistent with other languages and it creates discussion / lack of understanding etc. One possibility could be to respect instead the user choice made with
.editorconfig'sinsert_final_newlineoption. Hence this PR.In a follow-up, we'd use that
insertFinalNewlineoption in handlebars printer to insert or remove the final newline.Links