Using node-fs-extra with pkg (create executables) is causing an error in universalify

[Infern1]

• Operating System:
• Windows Server 2019
• Node.js version:
• Node LTS 32bit 14.161.1
• fs-extra version:
• 10.0.0

I'm using pkg for creating binaries of my NodeJS program. When running directly via NodeJS everything is working as should. However when I created my executable now with fs-extra it stops:

λ .\web_server.exe            
pkg/prelude/bootstrap.js:1359                                                                                                      
      throw error;                                                                                                                 
      ^                                                                                                                            
                                                                                                                                   
TypeError: Cannot read property 'name' of undefined                                                                                
    at C:\snapshot\\WEB_ServerTs\node_modules\fs-extra\node_modules\universalify\index.js:15:26                               
    at Object.<anonymous> (C:\snapshot\WEB_ServerTs\node_modules\fs-extra\lib\fs\index.js:57:27)                             
    at Module._compile (pkg/prelude/bootstrap.js:1433:22)                                                                          
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1218:10)                                                      
    at Module.load (internal/modules/cjs/loader.js:1047:32)                                                                        
    at Function.Module._load (internal/modules/cjs/loader.js:935:14)                                                               
    at Module.require (internal/modules/cjs/loader.js:1087:19)                                                                     
    at Module.require (pkg/prelude/bootstrap.js:1338:31)                                                                           
    at require (internal/modules/cjs/helpers.js:73:18)                                                                             
    at Object.<anonymous> (C:\snapshot\Linde\WEB_ServerTs\node_modules\fs-extra\lib\index.js:5:6)                                  

I tried to look in index.js from universalify however at least for me it doesn't make sense.

exports.fromCallback = function (fn) {
  return Object.defineProperty(function (...args) {
    if (typeof args[args.length - 1] === 'function') fn.apply(this, args)
    else {
      return new Promise((resolve, reject) => {
        fn.call(
          this,
          ...args,
          (err, res) => (err != null) ? reject(err) : resolve(res)
        )
      })
    }
  }, 'name', { value: fn.name })
}

[RyanZim]

It seems pkg somehow doesn't provide fs.realpath.native, which is a function we need to add promise support to. As a result, universalify attempts to read fn.name from fs.realpath.native, which is undefined, resulting in the error. What target are you compiling to with pkg?

[Infern1]

Target for compiling is windows x86

[Infern1]

fixed in pkg, thanks for pointing out the problem

[quinnturner]

FYI to others, there's a similar issue when using DataDog Trace.

[aboe026]

@Infern1, I'm seeing the same error with pkg. Is this a pkg problem then? If so, any idea when that fix will get released? Or the latest pkg release where this wasn't broken?

[aboe026]

Anecdotally, it seems that I am able to use the latest version of pkg (5.1.0) with the 9.1.0 release of fs-extra without running into this issue, but bumping fs-extra to 10.0.0 causes this error to happen.

[Infern1]

@Infern1, I'm seeing the same error with pkg. Is this a pkg problem then? If so, any idea when that fix will get released? Or the latest pkg release where this wasn't broken?

So patch is merged in pkg, no clue when they plan to release a new version. At least with the fix in place it is working. Using npm from git

[BenjD90]

@Infern1 It seams to be release in version 5.2.0 of pkg : https:/vercel/pkg/releases/tag/5.2.0

I still doesn't understand the link with fs-extra, there is not pkg dependency I think ? For now I'll rollback to v 9.1.0

[BenjD90]

In my case it's the lib async-listener that remove the function realpath.native from fs 😨 , nothing associated to pkg :
https:/othiym23/async-listener/blob/master/index.js#L277

Thank you for the lead.

[donthijackthegit]

Same for [email protected], I have to downgrade fs-extra to 9.1.0 or I will have the same issue for compiled binary which target is linux.