Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't continue process after pagespeed task #26

Closed
konstantin24121 opened this issue Dec 13, 2015 · 7 comments
Closed

Don't continue process after pagespeed task #26

konstantin24121 opened this issue Dec 13, 2015 · 7 comments

Comments

@konstantin24121
Copy link

Stoped after print results. Any Ideas?

@konstantin24121
Copy link
Author

grunt 0.4.5 , Windows 8.1

@konstantin24121
Copy link
Author

Don't work multitask, stoped after print first results

@mkilpatrick
Copy link
Contributor

I'm also using grunt 0.4.5 and after the first process ends (either 1 or multiple paths), the process just hangs. It never completes to get to the next process if there is one, and it never completes if there is only one process.

I added some logging to pagespeed.coffee and see that there is an error in the catch statement of "[Error: Threshold of 70 not met with score of 0]" which is then not being released by done(err).

@mkilpatrick
Copy link
Contributor

It looks like the current count wasn't properly incrementing upon errors so the process would never complete. I've submitted a PR to fix it. #27

@muratozgul
Copy link

same problem (Max OSX 10.10.5, grunt 0.4.5)

@leptest
Copy link

leptest commented Feb 22, 2016

+1

@paulradzkov
Copy link

Same problem (grunt 1.0.1, node v5.11.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants