ISSUE-150: Validate RANDOM range input has the smaller number first

[dmalec]

Resolves #150

Summary

The RANDOM procedure does not check if the first parameter is less than the second parameter on the two input form. This change adds an explicit check and errors if the range is out of order based on the description of the procedure in the manual. It also permits RANDOM to accept a range including negative numbers.

Testing

Without this change, passing in a higher number first leads to unexpected results:

? PRINT (RANDOM 5 3)
825322468
?

After making this change, passing in a higher number will produce an error:

? PRINT (RANDOM 5 6)
6

? PRINT (RANDOM 6 5)
RANDOM doesn't like [6 5] as input

Which is equivalent to passing a negative number to the single input form:

? PRINT RANDOM 10
9

? PRINT RANDOM -10
RANDOM doesn't like -10 as input

This change also allows negative numbers in the range:

? PRINT (RANDOM -10 -5)
-7

? PRINT (RANDOM -10 10)
5

While also enforcing the ordering constraint on the range even when negative:

? PRINT (RANDOM -5 -10)
RANDOM doesn't like [-5 -10] as input

Test Environments

• OSX Catalina (10.15.7) w/ wxWidgets 3.0.5
• Ubuntu Bionic (18.04.5) w/ wxWidgets 3.0.5

• Windows 10 Pro (19045.2364) w/ wxWidgets 3.0.5

[jrincayc]

@dmalec Would you like this merged, or did you want to work on it more to fix the negative numbers problem as well?

[dmalec]

@dmalec Would you like this merged, or did you want to work on it more to fix the negative numbers problem as well?

@jrincayc - I'd like to work on it a bit more to fix the negative number problem; I'll mark it as in progress.

[dmalec]

@jrincayc - this PR now contains a proposed change for allowing negative numbers in ranges and is ready for re-review.

[jrincayc]

Reviewed and tested and I approve.