-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 can't parse this cookie header #188
Comments
It parses for me, can you elaborate on "can't parse it at all"? Is it that the quotes are left in? That was an intentional change in the release notes: https:/jshttp/cookie/releases/tag/v1.0.0, but I'm not against reverting in a 1.1 if it's needed for you. Do you have a use-case where cookies are set with quotes from different software? What do you use for |
You are right, it's the quotes that are the problem.
Yes, we are parsing cookies that are set by a different team's backend, some Haskell code I think. |
For now you can do this into the function decode(value) {
let str = value;
if (value.charAt(0) === '"') {
str = value.slice(1, -1);
}
try {
return decodeURIComponent(str);
} catch {
return str;
}
} Edit: If it's help I can also expose the existing |
This cookie header is fine with 0.7.2 version but 1.0.0 can't parse it at all. I have swapped letters and number so should not leak any real tokens 😅
The text was updated successfully, but these errors were encountered: