Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 can't parse this cookie header #188

Open
cattermo opened this issue Oct 10, 2024 · 3 comments
Open

v1 can't parse this cookie header #188

cattermo opened this issue Oct 10, 2024 · 3 comments

Comments

@cattermo
Copy link

This cookie header is fine with 0.7.2 version but 1.0.0 can't parse it at all. I have swapped letters and number so should not leak any real tokens 😅

id_token=eyJ0eXAiOiJKV1QiLCJhbGciOagpiwenagIsImtpZCI6IlQxU3QtZExUdnlXUmd4Ql82NzZ1OGtyWFMtSSJ9.eyJhdWQiOiIxMzFkY2E2Ni0wMGNkLTRkYWQtODYwNy04MjQ3NmY5MWQ0MWIiLCJpc3MiOiJodHRwczovL2xvZ2luLm1pY3Jvc29mdG9ubGluZS5jb20vMDE3N2YwYjgtMGEzNS00ZDNjLWJmYTQtMGI5YmM3ZDJmNjY4L3YyLjAiLCJpYXQiOjE3MDEyNjUzMTQsIm5iZiI6MTcwMTI2NTMxNCwiZXhwIjoxNzAxMjY5MjE0LCJhaW8iOiJBV1FBbS84VkFBQUFtY0dQYWpZdUhTcGNtbnpNMUI0aXFubHVZWSttRCtkWFliekk5UDBsOHNkRHo3cnJyMG91WEZrc0VXVXN1VmhuU0ZBT0t4NmtENjZ3bG5HQmR0RnNXbjR2dzhjZExuNVZQOHo2MUVEcmFaeGs4K1NOWUowNlNUM0JQUUVBWEQ3UCIsImVtYWlsIjoiY2xhcmEuYXR0ZXJtb0BzY3JpdmUuY29tIiwibmFtZSI6IkNsYXJhIEF0dGVybW8iLCJub25jZSI6IjB1R0R4cjVPR2wxbUdXZEk1K0F4dHJoNUFNdUJDQ3VTS3hsMXNFK1EycVFydGpjNEVoQXNHK2N5Mko0ZFlnUWcvbTc3a2lTcHlaamRWS2N4SlJKTExCMTU3bjBXcTM5d2xYWDJZVGlaRFdaNHNjRmxIdmwwK3ViZUZQQkZEZEo2M1g1aGxGclJ3U3dPTGpkTFI2cTd6T3BtQXNRRUFmaG9lWUExVmZ1dmpyMD0iLCJvaWQiOiI0OTZlOGY3Mi1hYmI2LTQ5MWYtYWQwMi0wNjM1N2IwMjZlN2IiLCJwcmVmZXJyZWRfdXNlcm5hbWUiOiJjbGFyYS5hdHRlcm1vQHNjcml2ZS5jb20iLCJyaCI6IjAuQVY0QXVQQjNBVFVLUEUyX3BBdWJ4OUwyYUdiS0hSUE5BSzFOaGdlQ1IyLVIxQnRlQUpFLiIsInJvbGVzIjpbIkV4cGVyaW1lbnRhbC5GZWF0dXJlcyIsIkFwaUtleXMiLCJPZmZib2FyZGluZy5OZXREb2N1bWVudHMiLCJJbnRlZ3JhdGlvbnMuVXBzYWxlcy5SZWFkT25seSIsIkludGVncmF0aW9ucy5DbGlvLlJlYWRPbmx5IiwiTWlkZGxld2FyZXMuMzY1aWQuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuTXNQb3dlckF1dG9tYXRlLlJlYWRPbmx5IiwiSW50ZWdyYXRpb25zLlphcGllci5SZWFkT25seSIsIk1pZGRsZXdhcmVzLkFyY2hpdmluZy5SZWFkT25seSIsIkludGVncmF0aW9ucy5Cb3guUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuU2FsZXNmb3JjZS5SZWFkT25seSIsIk1pZGRsZXdhcmVzLkJucFBhcmliYXNDYXJkaWYuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuU3ltcGEuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuR2VuZXJpY0ludGVncmF0aW9uIiwiSW50ZWdyYXRpb25zLkdvb2dsZUFkZG9uLlJlYWRPbmx5IiwiT2ZmYm9hcmRpbmcuT25lRHJpdmUiLCJJbnRlZ3JhdGlvbnMuTXNPZmZpY2VBZGRpbi5SZWFkT25seSIsIkludGVncmF0aW9ucy5MaW1lLlJlYWRPbmx5IiwiSW50ZWdyYXRpb25zLlN1cGVyT2ZmaWNlLlJlYWRPbmx5IiwiT2ZmYm9hcmRpbmcuU0ZUUCIsIkludGVncmF0aW9ucy5IdWJTcG90LlJlYWRPbmx5IiwiSW50ZWdyYXRpb25zLk1zU2hhcmVQb2ludC5SZWFkT25seSIsIkludGVncmF0aW9ucy5OZXREb2N1bWVudHMuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuU2xhY2suUmVhZE9ubHkiLCJPZmZib2FyZGluZy5Ecm9wYm94IiwiSW50ZWdyYXRpb25zLlRlYW10YWlsb3IuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuTGltZSIsIk9mZmJvYXJkaW5nLkJveCIsIkludGVncmF0aW9ucy5QaXBlZHJpdmUuUmVhZE9ubHkiLCJJbnRlZ3JhdGlvbnMuTXNEeW5hbWljcy5SZWFkT25seSIsIk1pZGRsZXdhcmVzLkdPLlJlYWRPbmx5IiwiSW50ZWdyYXRpb25zLlN1Z2FyQ1JNSDFAGHFRPbmx5IiwiT2ZmYm9hcmRpbmcuU2hhcmVQb2ludCIsIkludGVncmF0aW9ucy5HZW5lcmljSW50ZWdyYXRpb24uUmVhZE9ubHkiLCJPZmZib2FyZGluZy5Hb29nbGVEcml2ZSJdLCJzdWIiOiJINGl6RllJcFI2WVdyTXdDZEk0NXRCOUNRenZjSE5pMXl4eDRpVFY1NS1jIiwidGlkIjoiMDE3N2YwYjgtMGEzNS00ZDNjLWJmYTQtMGI5YmM3ZDJmNjY4IiwidXRpIjoiYmpEOUFrNUxLRW1scGJvRFo5R1dBZyIsInZlciI6IjIuMCJ9.AQCgbUpu5JsffoRo4yKY9GdvM2npUrxkTjm9w5O7tYfF5HLgB8E1jEBIYrhnuxIkn-ReiziYVN8_qyiaEbI5Ypbjn7-BoxAcF5HjbJND9RY3zQ6zLGFgfUI338l15_pI5nHRVfteWjuylhm_tV7Rcj5KEKiBgN2S_6qLH2SdmXBhh_Z-DKKTARTHILZXPqDmuJAkxvrwFL6eiS-4k_9hsv8wIq4ClwvQRKzgRVEdrC119c3koqvfYNGG9VoJshlhqFdK42HdVE_Xfci4b597P-bMeU1YFSaCjloE3RqoRgPEiblaQE0q3_qRbxVlL_Haji9a1cNI6J5N-pFcBLO_RQ; .AspNetCore.Antiforgery.VyLW6ORzMgk=CfDJ8JDZOBm9tZdFqNBCeq_ziFAC2ZxLtPBGuob6b_l6GrROZ8FCLA-UjBTlZto-nJOC_nR6h2dyxPEJxloig0xDfrUAoZK_Fr2CgL8X9WJSK5eCKMu4aqlL1uquuw63B6WcTXEo9Z0KPGXglGdaxv6LWzw; .AspNetCore.Antiforgery.NpoYw6PJ4Jk=CfDJ8HQsOlIAijNAjLsRvnNW3zHkaFTRpBNChffVw82KM4UIybRhm2JtGxjrXJlDr1JT6bT1yHWtk-sfmBtVfrCbZHmQ16-wHYlwofbyO2W9j1ygLc-XTu63bpbXQinbIbAJ9Vk1gWN6znnOJnQWw6y-oeo; lang-ssn="en"; lang="en"; lang-ssn="en"; _ga=GA1.1.1029988250.1718788396; _ga_699NE13B0K=GS1.1.1720186252.2.0.1720186256.0.0.0; INGRESSCOOKIE=1727947792.318.169.452764|68391asdfw41b600eda7bcd531034c3; .AspNetCore.Antiforgery.ECfmJDHljzI=CfDJ8KbDosu-zd1GtP906ST7Hlu3QKPl76wzC_FY6-uRyH-XvJ10aBDOw0PCGzWpihF2NixBLQYktBICMBszIfv7SIn3nCUH691gJDpOuRPZKEWX-_m3ER4ZlW7saN8TXIDXUGAtsHHW0OV2XX7kKZlGbEA; EpicShop_CH-prefers-color-scheme=light; EpicShop_CH-time-zone=Europe%2FStockholm; EpicShop_CH-reduced-motion=no-preference; muxData==undefined&mux_viewer_id=065f569c-6d30-4d50-8a60-9e5da55bea26&msn=0.56630343630635071&sid=28d98e71-1067-400d-9966-4b0e8ed96efb&sst=1728409844522&sex=1728411344522; xtoken="ab455781a45c59ce"; sessionId="2044801-226b5233a4aqwg8"
@blakeembrey
Copy link
Member

blakeembrey commented Oct 10, 2024

It parses for me, can you elaborate on "can't parse it at all"? Is it that the quotes are left in? That was an intentional change in the release notes: https:/jshttp/cookie/releases/tag/v1.0.0, but I'm not against reverting in a 1.1 if it's needed for you.

Do you have a use-case where cookies are set with quotes from different software? What do you use for decode/encode?

@cattermo
Copy link
Author

You are right, it's the quotes that are the problem.

Do you have a use-case where cookies are set with quotes from different software?

Yes, we are parsing cookies that are set by a different team's backend, some Haskell code I think.
Maybe more people have this problem and the library removing the extra quotes is a good thing. I'll leave that for you to decide.

@blakeembrey
Copy link
Member

blakeembrey commented Oct 11, 2024

For now you can do this into the decode function, if you want quotes to be removed. For example:

function decode(value) {
  let str = value;
  if (value.charAt(0) === '"') {
    str = value.slice(1, -1);
  }
  try {
    return decodeURIComponent(str);
  } catch {
    return str;
  }
}

Edit: If it's help I can also expose the existing decode function used by the library, it's basically that try..catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants