Added Suspendable Open Calls #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
+ Coverage 95.76% 95.88% +0.12%
Complexity 151 151
============================================
Files 21 21
Lines 897 924 +27
Branches 68 68
============================================
+ Hits 859 886 +27
Misses 15 15
Partials 23 23
Continue to review full report at Codecov.
|
- updated README.md - added equivalent suspend aware open csv calls - added respectively suspend open call tests
blackmo18
force-pushed
the
enhancement/read-in-suspending-function
branch
from
4640d1f
to
8601d8f
Compare
| * | ||
| * Usage example: | ||
| * <pre> | ||
| * val data: Sequence<List<String?>> = csvReader().open("test.csv") { |
There was a problem hiding this comment.
Applied Changest at 9369a15
| @@ -253,6 +255,44 @@ class CsvReaderTest : WordSpec() { | |||
| } | |||
| rows shouldBe listOf(listOf("a", "b", "c"), listOf("d", "e", "f")) | |||
| } | |||
| "execute as suspending function" should { | |||
There was a problem hiding this comment.
It would be better to use suspend fun inside openAsync method because these tests are for that use-case.
A suspend fun sample is written on Issue #66 (comment) . (processRow method)
There was a problem hiding this comment.
Yes I agree, but for the reason for test consistency of validating rows, I chose to use the kotlin asnyc flow.
The collect is a supending function, which i think cover the scenario we need.
#66 Added Suspendable Open Calls