Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace angular.uppercase with String.prototype.toUpperCase() (master/v0.8.13) #977

Merged
merged 1 commit into from
Jun 24, 2018

Conversation

rthaut
Copy link
Contributor

@rthaut rthaut commented Jun 24, 2018

Description

Note that I also created a PR for the develop branch (v1.0), so please do not consider this to be a duplicate (although the fix is the same).

This PR replaces the use of angular.uppercase with String.prototype.toUpperCase(), as AngularJS has removed their helper functions.

This PR is intentionally targeted for the master branch, despite the instructions in the contribution guidelines. This fix is necessary for production systems currently using the latest stable version of AngularJS. Since v0.8.13 is still listed as the primary version on NPM, and since v1.0 has been in development for quite some time, it seems reasonable that this fix should be released for v0.8.13 (or v0.8.14, as the case may be) right away.

Fixes Related issues

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

@Anthropic Anthropic merged commit 413b0a9 into json-schema-form:master Jun 24, 2018
@Anthropic
Copy link
Member

@rthaut you could add it to the support/0.x branch as well that is actually the latest version of 0.8.x and has a lot more added to it than master, so if I do a new release I'd probably want to do it from there.

If you can pull that and test it for me I'd feel safer to know it works, there's no tests working on that branch which is why I haven't done any further releases on the code I didn't really write much of myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants