move validation of LHS of := from evaluator to parser #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbaileyuk
approved these changes
Feb 15, 2018
mtiller
added a commit
to mtiller/jsonata
that referenced
this pull request
Mar 7, 2018
See jsonata-js#148 and jsonata-js#150 for details about why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left hand side of the binding operator
:=must be a variable. This PR moves the validation of this rule from the evaluator (which throws a dynamic error) to the parser (throws a syntax error). This is also more robust since it is checking against the token type rather than a node in the AST.Resolves #148 which was ignoring the predicate attached to the variable in the AST.