Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex no longer relies on global state (lastIndex) #226

Merged
merged 2 commits into from
May 23, 2018
Merged

regex no longer relies on global state (lastIndex) #226

merged 2 commits into from
May 23, 2018

Conversation

andrew-coleman
Copy link
Member

Minor change to remove reliance on lastIndex in the global RegExp object.

resolves #205

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e2347d on regex_state into 444325c on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e2347d on regex_state into 444325c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e2347d on regex_state into 444325c on master.

@coveralls
Copy link

coveralls commented May 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6accfac on regex_state into 3c50c69 on master.

@andrew-coleman andrew-coleman merged commit 7cc2b0b into master May 23, 2018
@andrew-coleman andrew-coleman deleted the regex_state branch May 23, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbaileyuk mattbaileyuk mattbaileyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lastIndex unused
3 participants
@andrew-coleman @coveralls @mattbaileyuk