Added extension version and type to ExtensionManager.ts #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 054ba1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jodeleeuw
reviewed
Jul 18, 2024
| @@ -58,10 +58,18 @@ class RecordVideoExtension implements JsPsychExtension { | |||
|
|
|||
| if (!this.currentTrialData.record_video_data) { | |||
| this.onUpdateCallback = () => { | |||
| resolve(this.currentTrialData); | |||
| resolve({ | |||
There was a problem hiding this comment.
Hmm - shouldn't we be able to add this in the core library so each extension doesn't need to do it manually?
There was a problem hiding this comment.
Yes! This has been changed.
Bankminer78
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives JsPsych the general functionality of adding an extension's version and type to the data it generates in a trial data object. It does so by drawing the name and version from the info property of an extension's class. This PR also reverts changes made to extensions to return version and type as extra data fields. All extensions with a complete info property will now experience the benefit of their version and type being appended to their data by JsPsych.