Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 update #144

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

v8 update #144

wants to merge 30 commits into from

Conversation

jadeddelta
Copy link
Collaborator

@jadeddelta jadeddelta commented Oct 17, 2024

this PR closes #138, focusing broadly on updating most plugins to jspsych v8, which necessitates breaking changes for all plugins as certain features handled by the core package like clearing timers/displays are left to the core package itself, along with certain plugins such as the audio plugins and plugins with button_html-esque fields being updated.

in order to improve developer experience, some plugins have added documentation where it was missing beforehand.

while all plugins function in v8, to move this PR off of draft and into merge consideration, there are several final passes and one blocking issue to content with:

  • final pass on documentation, making sure all parameters and data are documented
  • clarification on ParameterType.COMPLEX data types, specifically listing and documenting nested variables
  • changelog everything
  • this pr for letting json files be imported as modules, so that we can...
  • link package.json versioning to plugin info versioning

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: b250c20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@jspsych-contrib/plugin-video-several-keyboard-responses Major
@jspsych-contrib/plugin-image-array-keyboard-response Major
@jspsych-contrib/plugin-html-keyboard-response-raf Major
@jspsych-contrib/plugin-libet-intentional-binding Major
@jspsych-contrib/plugin-vsl-animate-occlusion Major
@jspsych-contrib/plugin-audio-multi-response Major
@jspsych-contrib/plugin-audio-swipe-response Major
@jspsych-contrib/plugin-html-keyboard-slider Major
@jspsych-contrib/plugin-image-multi-response Major
@jspsych-contrib/plugin-image-swipe-response Major
@jspsych-contrib/plugin-html-multi-response Major
@jspsych-contrib/plugin-html-swipe-response Major
@jspsych-contrib/plugin-nextcloud-filedrop Major
@jspsych-contrib/plugin-self-paced-reading Major
@jspsych-contrib/plugin-html-vas-response Major
@jspsych-contrib/plugin-vsl-grid-scene Major
@jspsych-contrib/plugin-survey-number Major
@jspsych-contrib/plugin-survey-slider Major
@jspsych-contrib/plugin-copying-task Major
@jspsych-contrib/plugin-corsi-blocks Major
@jspsych-contrib/plugin-html-choice Major
@jspsych-contrib/plugin-gamepad Major
@jspsych-contrib/plugin-ios Major
@jspsych-contrib/plugin-rdk Major
@jspsych-contrib/plugin-rok Major
@jspsych-contrib/plugin-pipe Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jodeleeuw jodeleeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed a couple files as a demonstration of code review

@@ -1,42 +1,42 @@
# jspsych-audio-multi-response plugin

This plugin plays an audio file and records responses generated by both button click and the keyboard. Allowing multiple response modalities is useful when designing assessments that will be administered on both desktop and mobile (e.g., phone or tablet) devices. The stimulus can be displayed until a response is given, or for a pre-determined amount of time. The trial can be ended automatically if the subject has failed to respond within a fixed length of time.
This plugin plays an audio file and records responses generated by both button click and the keyboard. Allowing multiple response modalities is useful when designing assessments that will be administered on both desktop and mobile (e.g., phone or tablet) devices. The stimulus can be displayed until a response is given, or for a pre-determined amount of time. The trial can be ended automatically iparticipant has failed to respond within a fixed length of time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contrib plugins to version 8.0
2 participants