-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 update #144
base: main
Are you sure you want to change the base?
v8 update #144
Conversation
🦋 Changeset detectedLatest commit: b250c20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed a couple files as a demonstration of code review
@@ -1,42 +1,42 @@ | |||
# jspsych-audio-multi-response plugin | |||
|
|||
This plugin plays an audio file and records responses generated by both button click and the keyboard. Allowing multiple response modalities is useful when designing assessments that will be administered on both desktop and mobile (e.g., phone or tablet) devices. The stimulus can be displayed until a response is given, or for a pre-determined amount of time. The trial can be ended automatically if the subject has failed to respond within a fixed length of time. | |||
This plugin plays an audio file and records responses generated by both button click and the keyboard. Allowing multiple response modalities is useful when designing assessments that will be administered on both desktop and mobile (e.g., phone or tablet) devices. The stimulus can be displayed until a response is given, or for a pre-determined amount of time. The trial can be ended automatically iparticipant has failed to respond within a fixed length of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here
this PR closes #138, focusing broadly on updating most plugins to jspsych v8, which necessitates breaking changes for all plugins as certain features handled by the core package like clearing timers/displays are left to the core package itself, along with certain plugins such as the audio plugins and plugins with
button_html
-esque fields being updated.in order to improve developer experience, some plugins have added documentation where it was missing beforehand.
while all plugins function in v8, to move this PR off of draft and into merge consideration, there are several final passes and one blocking issue to content with:
ParameterType.COMPLEX
data types, specifically listing and documenting nested variablespackage.json
versioning to plugin info versioning