-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] jsx-wrap-multilines
: add never
option to prohibit wrapping parens on multiline JSX
#3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parens on multiline JSX
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 132 132
Lines 9375 9379 +4
Branches 3432 3433 +1
=======================================
+ Hits 9155 9159 +4
Misses 220 220 ☔ View full report in Codecov by Sentry. |
ljharb
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style is atrocious, but your PR is good. Thanks!
ljharb
changed the title
never wrap multilines
[New] Dec 15, 2023
react/jsx-wrap-multilines
: add never
option to prohibit wrapping parens on multiline JSX
Relates to #1039 as well, i think. |
ljharb
changed the title
[New]
[New] Dec 15, 2023
react/jsx-wrap-multilines
: add never
option to prohibit wrapping parens on multiline JSXjsx-wrap-multilines
: add never
option to prohibit wrapping parens on multiline JSX
This was referenced May 24, 2024
This was referenced Jun 18, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1035
First PR here so if I'm missing anything please let me know!
(Also I'm aware this particular option is very controversial, please don't hate me 😇)