test

.github/workflows/tests.yaml

@@ -13,11 +13,13 @@ jobs:
  name: "Linux Tests"
  strategy:
  matrix:
- container: ["centos:7", "ubuntu:18.04"]
- node: [12, 14]
+ container: ["ubuntu:18.04"]
+ node: [18, 20, 22]
  runs-on: ubuntu-latest
  container:
  image: ${{ matrix.container }}
+ env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
  steps:
  - uses: actions/checkout@v2
 
@@ -43,44 +45,44 @@ jobs:
  yarn
  yarn test
 
- macos-tests:
- name: "MacOS Tests"
- strategy:
- matrix:
- node: [12, 14]
- runs-on: macOS-latest
- steps:
- - uses: actions/checkout@v2
+ # macos-tests:
+ #  name: "MacOS Tests"
+ #  strategy:
+ #  matrix:
+ #  node: [16, 18, 20, 22]
+ #  runs-on: macOS-latest
+ #  steps:
+ #  - uses: actions/checkout@v4
 
- - name: Use Node.js ${{ matrix.node }}
- uses: actions/setup-node@v2
- with:
- node-version: ${{ matrix.node }}
- check-latest: true
+ #  - name: Use Node.js ${{ matrix.node }}
+ #  uses: actions/setup-node@v4
+ #  with:
+ #  node-version: ${{ matrix.node }}
+ #  check-latest: true
 
- - run: |
- npm install --global yarn
- yarn
- yarn test
+ #  - run: |
+ #  npm install --global yarn
+ #  yarn
+ #  yarn test
 
- windows-tests:
- name: "Windows Tests"
- strategy:
- matrix:
- node: [12, 14]
- runs-on: windows-latest
- steps:
- - uses: actions/checkout@v2
+ # windows-tests:
+ #  name: "Windows Tests"
+ #  strategy:
+ #  matrix:
+ #  node: [12, 14]
+ #  runs-on: windows-latest
+ #  steps:
+ #  - uses: actions/checkout@v4
 
- - name: Use Node.js ${{ matrix.node }}
- uses: actions/setup-node@v2
- with:
- node-version: ${{ matrix.node }}
- check-latest: true
+ #  - name: Use Node.js ${{ matrix.node }}
+ #  uses: actions/setup-node@v4
+ #  with:
+ #  node-version: ${{ matrix.node }}
+ #  check-latest: true
 
- - run: |
- npm install --global yarn
- npm install --global [email protected]
- npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"}
- yarn
- yarn test
+ #  - run: |
+ #  npm install --global yarn
+ #  npm install --global [email protected]
+ #  npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"}
+ #  yarn
+ #  yarn test

binding.gyp

@@ -29,10 +29,10 @@
  ],
  "msvs_settings": {
  "VCCLCompilerTool": {
- "DisableSpecificWarnings": [ "4506", "4538", "4793" ]
+ "DisableSpecificWarnings": [ ]
  },
  "VCLinkerTool": {
- "AdditionalOptions": [ "/ignore:4248" ]
+ "AdditionalOptions": [ ]
  }
  }
  }],

includes/win32/Watcher.h

@@ -37,10 +37,10 @@ class Watcher
  void resizeBuffers(std::size_t size);
 
  std::string getUTF8Directory(std::wstring path) ;
- bool Watcher::isExcluded(const std::wstring &fileName);
+ bool isExcluded(const std::wstring &fileName);
 
- std::wstring Watcher::getWatchedPathFromHandle();
- void Watcher::checkWatchedPath();
+ std::wstring getWatchedPathFromHandle();
+ void checkWatchedPath();
 
  std::atomic<bool> mRunning;
  SingleshotSemaphore mHasStartedSemaphore;

package.json

@@ -30,7 +30,7 @@
  ],
  "homepage": "https:/axosoft/node-simple-file-watcher",
  "dependencies": {
- "node-addon-api": "^5.0.0"
+ "node-addon-api": "*"
  },
  "devDependencies": {
  "eslint": "^6.8.0",