-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout parameter on @Test Annotation does not override Timeout Rule #1126
Comments
Edit: We could set a |
@kcooney seems like the dirty hack. What about remove Also after this change test methods with timeout parameter will run in the same thread which runs the fixture's @before and @after methods. |
@baev |
@baev good point! We could make
Calling the |
BTW we can return empty
Agree. Personally i would like to deprecate |
or we can use |
The |
There are problems with timeout architecture - two different ways to specify timeouts, with different behavior. Using |
@baev having timeouts more clear and flexible would be nice. Can we think of a simple path to get there? Having the code that handles the One thing I like about the |
Inheritance is not taken into account for Junit @timeout rules. This means that if several @timeout rules are present in the class inheritance chain, and even if timeout is specified as an attribute of the @test annotation, the minimal timeout would be decisive. This fix allows classes extending from ITextTest setting bigger timeout for tests. Previously it was only possible to make timeout smaller due to the fact described above. See also junit-team/junit4#1126
Allow overriding test timeout for classes extending from ITextTest Inheritance is not taken into account for Junit @timeout rules. This means that if several @timeout rules are present in the class inheritance chain, and even if timeout is specified as an attribute of the @test annotation, the minimal timeout would be decisive. This fix allows classes extending from ITextTest setting bigger timeout for tests. Previously it was only possible to make timeout smaller due to the fact described above. See also junit-team/junit4#1126 Autoported commit. Original commit hash: [f426323a0] Manual files: pdftest/src/main/java/com/itextpdf/test/ITextTest.java
I refer to https:/junit-team/junit/wiki/Timeout-for-tests
If I use
the test schould timeout afer 20s but it times out after 10s
The text was updated successfully, but these errors were encountered: