Scheduler update apis are not consistent with REST APIs

[3coins]

Problem

Scheduler update APIs are using models that require job_id or job_definition_id as required attributes. This means, that the payload from the REST call has to include these. This is inconsistent with the REST APIs, as the ids should be populated from the path query.

Proposed Solution

• Remove job_id from UpdateJob model
• Update definition of update_job in Scheduler.py to take job_id as one of the inputs
• Remove job_definition_id from UpdateJobDefinition model
• Update definition of update_job_definition in Scheduler.py to take job_definition_id as one of the inputs.

Additional context

jupyter-scheduler/jupyter_scheduler/models.py

Lines 146 to 152 in 9b08703

	class UpdateJob(BaseModel):
	job_id: str
	end_time: Optional[int] = None
	status: Optional[Status] = None
	status_message: Optional[str] = None
	name: Optional[str] = None
	compute_type: Optional[str] = None

jupyter-scheduler/jupyter_scheduler/models.py

Lines 184 to 198 in 9b08703

	class UpdateJobDefinition(BaseModel):
	job_definition_id: str
	input_uri: Optional[str]
	output_prefix: Optional[str]
	runtime_environment_name: Optional[str]
	runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
	output_formats: Optional[List[str]] = None
	parameters: Optional[Dict[str, ParameterValues]] = None
	tags: Optional[Tags] = None
	name: Optional[str] = None
	url: Optional[str] = None
	schedule: Optional[str] = None
	timezone: Optional[str] = None # Should be a timezone e.g., US/Eastern, Asia/Kolkata
	output_filename_template: Optional[str] = OUTPUT_FILENAME_TEMPLATE
	active: Optional[bool] = None

jupyter-scheduler/jupyter_scheduler/scheduler.py

Line 49 in 9b08703

def update_job(self, model: UpdateJob):

jupyter-scheduler/jupyter_scheduler/scheduler.py

Line 99 in 9b08703

def update_job_definition(self, model: UpdateJobDefinition):