Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation for stop with visual feedback on request for Job List, Job Detail #245

Merged
merged 8 commits into from
Nov 1, 2022
Merged

Confirmation for stop with visual feedback on request for Job List, Job Detail #245

merged 8 commits into from
Nov 1, 2022

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Nov 1, 2022 •
edited
Loading

Description

  • "Stop" icon in Job List would now show "Stop" confirmation button on click. On click on "Stop" confirmation button and until page is reloaded, Chip element with "Stopping" text would be shown
  • "Stop" button in Job Detail page would now show confirmation dialogue before attempting to stop the job. While element is attempting to stop the job (after dialog is confirmed and closed), chip reading "Stopping" would be shown instead of "Stop" button
  • Fixes Confirmation for stop, visual feedback on request #223

Preview

  • List view:
    list_confirm_stop

  • Detail view:
    details_confirm_stop

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Binder 👈 Launch a Binder on branch andrii-i/jupyter-scheduler/stop-confirmation

@andrii-i andrii-i changed the title Stop confirmation Stop confirmation for Job List, Job Detail Nov 1, 2022
@andrii-i andrii-i changed the title Stop confirmation for Job List, Job Detail Stop with confirmation and feedback for Job List, Job Detail Nov 1, 2022
@andrii-i andrii-i added the enhancement New feature or request label Nov 1, 2022
@andrii-i andrii-i changed the title Stop with confirmation and feedback for Job List, Job Detail Confirmation for stop with visual feedback on request for Job List, Job Detail Nov 1, 2022
dlqqq
dlqqq requested changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great aside from some naming changes that are needed. Thank you for refactoring our confirmation logic into a separate component!

src/components/confirm-buttons.tsx Outdated Show resolved Hide resolved
src/components/confirm-buttons.tsx Outdated Show resolved Hide resolved
src/components/confirm-buttons.tsx Outdated Show resolved Hide resolved
src/components/confirm-icons.tsx Outdated Show resolved Hide resolved
src/components/confirm-icons.tsx Outdated Show resolved Hide resolved
src/components/confirm-buttons.tsx Outdated Show resolved Hide resolved
@andrii-i andrii-i mentioned this pull request Nov 1, 2022
Open
@andrii-i andrii-i requested a review from dlqqq November 1, 2022 20:50
@andrii-i andrii-i merged commit 692bc8a into jupyter-server:main Nov 1, 2022
@andrii-i andrii-i deleted the stop-confirmation branch November 1, 2022 22:03
@andrii-i andrii-i restored the stop-confirmation branch November 2, 2022 20:09
@andrii-i andrii-i deleted the stop-confirmation branch November 2, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirmation for stop, visual feedback on request
3 participants
@andrii-i @dlqqq @JasonWeill