Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow arbitrary expressions as job parameters #247

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Nov 1, 2022

Allows for any expressions valid to the notebook kernel to be used as job parameters.

Now requires strings to be explicitly wrapped in single or double quotes.

Screen.Recording.2022-11-01.at.10.37.03.AM.mov

Closes #229.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Binder 👈 Launch a Binder on branch dlqqq/jupyter-scheduler/allow-all-parameter-expressions

@dlqqq dlqqq added the enhancement New feature or request label Nov 1, 2022
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
src/handler.ts Outdated Show resolved Hide resolved
Co-authored-by: Piyush Jain <[email protected]>
@dlqqq dlqqq merged commit 0b6c21b into jupyter-server:main Nov 1, 2022
@dlqqq dlqqq deleted the allow-all-parameter-expressions branch November 1, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate parameter handling
2 participants