Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-note-icon): add viewBox attr to svg so it resizes #333

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

maxime-helen
Copy link
Contributor

@maxime-helen maxime-helen commented Jan 6, 2023

Bringing this fix as Sagemaker Studio couldn't resize the icon associated to "scheduling:show-notebook-jobs" command, added to the new Studio launcher with a smaller size than before

See this codepen for more infos https://codepen.io/tefa-dev/pen/gOjLZQZ, the icon doesn't resize without viewBox

@welcome
Copy link

welcome bot commented Jan 6, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Binder 👈 Launch a Binder on branch maxime-helen/jupyter-scheduler/maxime/fix-icon

@dlqqq dlqqq added the bug Something isn't working label Jan 19, 2023
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxime-helen Great catch, thank you! CI failures not related.

@dlqqq dlqqq merged commit f70edc4 into jupyter-server:main Jan 19, 2023
@welcome
Copy link

welcome bot commented Jan 19, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants