Add full-widget-sized job detail view #46
Conversation
|
|
|
|
||
| export interface IJobDetailProps { | ||
| app: JupyterFrontEnd; | ||
| model: IJobDetailModel; | ||
| modelChanged: (model: IJobDetailModel) => void; |
There was a problem hiding this comment.
Nothing for you to do right now, but when #44 is merged in, there will be a conflict because this is being renamed to handleModelChange.
src/mainviews/job-detail.tsx
Outdated
| /> | ||
| <TextFieldStyled | ||
| label={trans.__('start_time')} | ||
| defaultValue={job?.start_time?.toString() ?? ''} |
There was a problem hiding this comment.
This should be converted from epoch seconds to a readable format (see the existing list view for more about how we do this)
There was a problem hiding this comment.
Feel free to open another issue if this is too complex to do right now.
There was a problem hiding this comment.
Adapted your solution, otherwise would probably be too complex for now
src/mainviews/job-detail.tsx
Outdated
| }} | ||
| /> | ||
| <TextFieldStyled | ||
| label={trans.__('start_time')} |
There was a problem hiding this comment.
This field is already mentioned on line 305 above. Delete one occurrence of it.
There was a problem hiding this comment.
Removed 305 occurence
src/mainviews/job-detail.tsx
Outdated
| }} | ||
| /> | ||
| <TextFieldStyled | ||
| label={trans.__('status_message')} |
There was a problem hiding this comment.
| label={trans.__('status_message')} | |
| label={trans.__('Status message')} |
Shouldn't this be displayed right after "Status"?
There was a problem hiding this comment.
As it is now, status_message is always null in job object that server/API returns based on jobId while status contains actual status enum / string
There was a problem hiding this comment.
status_message removed completely as it's not implemented
src/mainviews/job-detail.tsx
Outdated
| /> | ||
| <TextFieldStyled | ||
| label={trans.__('end_time')} | ||
| defaultValue={job?.end_time?.toString() ?? ''} |
There was a problem hiding this comment.
This should be converted from epoch seconds to a human-readable format.
There was a problem hiding this comment.
Done, adapted your solution
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
|
All comments are solved / answered |
This PR adds full-widget-sized job details view as per Issue #5
Currently all fields of IDescribeJob (that extends ICreateJob) are rendered even if they are not filled. email_notifications field is not rendered