Pydantic v1 and v2 compatibility, add pydantic_v1 module
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
force-pushed
the
pydantic-v2
branch
from
0e6d887
to
c4cb1ca
Compare
dlqqq
requested changes
Nov 14, 2023
Co-authored-by: david qiu <[email protected]>
dlqqq
changed the title
pydantic_v1 module
JasonWeill
added a commit
to JasonWeill/jupyter-scheduler
that referenced
this pull request
Nov 15, 2023
…erver#463) * Custom module to allow Pydantic v1 and v2 compatibility * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update jupyter_scheduler/pydantic_v1/__init__.py Co-authored-by: david qiu <[email protected]> * Removes unneeded logic * Adds dataclasses.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]>
Merged
JasonWeill
added a commit
that referenced
this pull request
Nov 15, 2023
* Custom module to allow Pydantic v1 and v2 compatibility * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update jupyter_scheduler/pydantic_v1/__init__.py * Removes unneeded logic * Adds dataclasses.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]>
andrii-i
pushed a commit
to andrii-i/jupyter-scheduler
that referenced
this pull request
Apr 16, 2024
…erver#463) * Custom module to allow Pydantic v1 and v2 compatibility * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update jupyter_scheduler/pydantic_v1/__init__.py Co-authored-by: david qiu <[email protected]> * Removes unneeded logic * Adds dataclasses.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]>
andrii-i
added a commit
that referenced
this pull request
Apr 16, 2024
…ydantic_v1 module, add pytest-cov dependency (#507) * ignore check-wheel-contents "W002" error during release as is done in main (#488) * update pre-commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Pydantic v1 and v2 compatibility, add `pydantic_v1` module (#463) * Custom module to allow Pydantic v1 and v2 compatibility * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update jupyter_scheduler/pydantic_v1/__init__.py Co-authored-by: david qiu <[email protected]> * Removes unneeded logic * Adds dataclasses.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]> * add pytest-cov optional dependency --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jason Weill <[email protected]> Co-authored-by: david qiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390. Inspired by LangChain, adds a module
jupyter_scheduler.pydantic_v1to expose the Pydantic v1 API to classes whether v1 or v2 is installed.Updates dependencies to allow v1 and v2 to be used. Updates classes to use the new dependency.
Tested locally with both Pydantic v1 and v2; working in both cases.