Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LICENSE #1197

Merged
merged 5 commits into from
Feb 2, 2023
Merged

update LICENSE #1197

merged 5 commits into from
Feb 2, 2023

Conversation

dcsaba89
Copy link
Contributor

@dcsaba89 dcsaba89 commented Feb 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 80.36% // Head: 80.39% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (251957c) compared to base (841a637).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   80.36%   80.39%   +0.03%     
==========================================
  Files          68       68              
  Lines        8117     8117              
  Branches     1584     1584              
==========================================
+ Hits         6523     6526       +3     
+ Misses       1178     1176       -2     
+ Partials      416      415       -1     
Impacted Files Coverage Δ
jupyter_server/extension/handler.py 67.69% <0.00%> (-1.54%) ⬇️
jupyter_server/gateway/managers.py 83.37% <0.00%> (-0.24%) ⬇️
...ter_server/services/kernels/connection/channels.py 62.16% <0.00%> (+1.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 2, 2023

Hi @blink1073, created a LICENSE file using Github's official BSD 3-Clause License template (as the idea to simply rename the file did not work, maybe because the original CHANGE.md was not created with that templace), but I kept most of the wording from the original CHANGE.md

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, let's see if it works this time! 😄

@blink1073 blink1073 merged commit 849c7b6 into jupyter-server:main Feb 2, 2023
@blink1073
Copy link
Contributor

Hmm, it still does not show up in the UI. It seems it does not like the extra content at the bottom, which we can't remove.

@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 2, 2023

Could you move it somewhere else? Would it be possible?

@blink1073
Copy link
Contributor

I don't think so, no. I think we've done as much as we can. We have a compliant license, we can't compromise it to conform to the GitHub UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants