Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YDocument a IObservableDisposable #108

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Make YDocument a IObservableDisposable #108

merged 1 commit into from
Dec 12, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Dec 6, 2022 •
edited
Loading

Make the document disposal observable. This allows to trigger additional clearing actions.

@fcollonval fcollonval added the enhancement New feature or request label Dec 7, 2022
@fcollonval fcollonval marked this pull request as ready for review December 7, 2022 08:53
hbcarlos
hbcarlos approved these changes Dec 11, 2022
View reviewed changes
Copy link
Contributor

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fcollonval!

@fcollonval fcollonval merged commit 7080c66 into jupyter-server:main Dec 12, 2022
@fcollonval fcollonval deleted the ft/document-are-observable-disposable branch December 12, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees

@fcollonval fcollonval

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @hbcarlos