Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cell.source is [list, of, string] #112

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

Wh1isper
Copy link
Contributor

Considering ysource: Y.Text in js model , it may be appropriate to adapt the list in the python model

@Wh1isper Wh1isper changed the title support cell.source is [list, of, string] Support cell.source is [list, of, string] Dec 15, 2022
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wh1isper.
Could we keep one notebook with two cells instead of two notebooks?

jupyter_ydoc/ydoc.py Outdated Show resolved Hide resolved
@davidbrochart
Copy link
Collaborator

Could we keep one notebook with two cells instead of two notebooks?

@Wh1isper Wh1isper closed this Dec 15, 2022
@Wh1isper Wh1isper deleted the list_of_str branch December 15, 2022 15:04
@Wh1isper Wh1isper restored the list_of_str branch December 15, 2022 15:04
@Wh1isper Wh1isper reopened this Dec 15, 2022
@Wh1isper
Copy link
Contributor Author

Could we keep one notebook with two cells instead of two notebooks?

Of course, sorry I just got your point and then got some operations wrong😂

But now everything looks good

jupyter_ydoc/ydoc.py Outdated Show resolved Hide resolved
tests/files/nb0.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbrochart davidbrochart added the bug Something isn't working label Dec 15, 2022
@davidbrochart davidbrochart merged commit eaaee5a into jupyter-server:main Dec 15, 2022
@welcome
Copy link

welcome bot commented Dec 15, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants