Improve Python API #122
Improve Python API #122
Conversation
|
@fcollonval I believe commit b7ab80a addresses your concerns in #65. See jupyterlab/jupyter-collaboration#72 for an example of the change required in the callback. |
Yes, thanks. |
davidbrochart
force-pushed
the
notebook
branch
from
ed0e943
to
d1380be
Compare
davidbrochart
force-pushed
the
notebook
branch
from
d1380be
to
a75ea4e
Compare
|
Commit a75ea4e partially addresses #123 by adding |
jupyter_ydoc/ydoc.py
Outdated
| @@ -153,9 +155,9 @@ def unobserve(self) -> None: | |||
| self._subscriptions = {} | |||
|
|
|||
|
|
|||
| class YFile(YBaseDoc): | |||
| class YUTF8(YBaseDoc): | |||
There was a problem hiding this comment.
Should we use something more generic like YText?
the idea is a bit like for YBytes to let the door open to other encoding. And also it is probably more easy to grasp.
There was a problem hiding this comment.
Should we use something more generic like YText?
Maybe, although YText already exists in y-py, but you're right, if they don't call it YUTF8 there then I guess there is no reason that we do it here.
the idea is a bit like for YBytes to let the door open to other encoding. And also it is probably more easy to grasp.
Actually I'd like to rename YBytes to YBlob, which reflects the idea that it's a whole chunk of data on which we cannot collaborate on an element basis. Also, it can store anything, not only bytes.
There was a problem hiding this comment.
04a7f74 renames YBytes to YBlob. Actually, it really stores bytes, which is fine since blob stands for "binary large object".
There was a problem hiding this comment.
Thanks for pointing the existing YText in y-py. So maybe YText here is not the most appropriate as it can generate confusion. I'm a bit short of idea - I thought about YStr or YString but i'm half convinced.
There was a problem hiding this comment.
Traitlets has Unicode. It's similar to the previous YUTF8, but maybe more inline with the rest of the Jupyter ecosystem?
for more information, see https://pre-commit.ci
davidbrochart
force-pushed
the
notebook
branch
from
04a7f74
to
9abd30b
Compare
Closes #65.