Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions to the Binder badge workflow #3212

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 9, 2021

Fix the permission of the Binder badge workflow so it can post the PR comment. Related to the recent GitHub changes on permission workflows.

Example PR where it failed: #3211

@jtpio
Copy link
Member Author

jtpio commented Jun 9, 2021

Still failing for now:

image

And would need to be merged into master to become effective.

@jtpio
Copy link
Member Author

jtpio commented Jun 30, 2021

So should we go ahead with this and add the new permissions? Or remove the Binder badge workflow?

@jasongrout jasongrout merged commit 269b6a6 into jupyter-widgets:master Jul 13, 2021
@jasongrout
Copy link
Member

Thanks!

@jtpio jtpio deleted the binder-badge-write branch August 31, 2021 13:08
@jasongrout jasongrout added this to the 8.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants