-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework R code separation #32
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the supporting R code is loaded, in
interpreter::configure_impl()
from a directory based on wherexr
is:That's a lot of hoops to call
source('setup.R')
that itselfsource()
the other files, which gives a cheap version of a package.We should probably :
IRkernel
i.e.IRkernel
minus the transport/zmq code..Call()
s back into the C++, i.e. theroutines.cpp
file. Those are systematic, so could definitely be generated, this does not necessarily need to be an.R
file. The decor 📦 could help.We could take inspiration from what
IRdisplay
does with options, e.g.The package would have functions such as
execute()
,complete()
etc ... and the C++ code would:.Call()
compatible C++ functionsThe win is that the package does not have to deal with C++ code, the option serves as a sort of pimpl.
The text was updated successfully, but these errors were encountered: