Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip R_LDFLAGS strings in FindR.cmake #3

Closed
wants to merge 2 commits into from
Closed

Strip R_LDFLAGS strings in FindR.cmake #3

wants to merge 2 commits into from

Conversation

SylvainCorlay
Copy link
Member

Attempting to fix the Windows build.

@SylvainCorlay
Copy link
Member Author

So we are now failing at the next step (configure passes, but build does not).

@JohanMabille
Copy link
Member

It tries to link with the .dll files instead of the companions .lib files.

@SylvainCorlay
Copy link
Member Author

Yeah, FindR returns the DLLs.

@romainfrancois

This comment was marked as off-topic.

Sign in to view
@romainfrancois
Copy link
Contributor

Moving the 🪡 a bit, now with this error :

D:\a\xeus-r\xeus-r\src\xinterpreter.cpp(28): fatal error C1083: Cannot open include file: 'Rinterface.h': No such file or directory

@romainfrancois
Copy link
Contributor

The Rinterface.h file is unix only, we're going to need to set the callbacks differently on windows. See https://vscode.dev/github/rstudio/rstudio/blob/main/src/cpp/r/session/REmbeddedWin32.cpp for how Rstudio does it.

@romainfrancois romainfrancois mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SylvainCorlay @JohanMabille @romainfrancois