Fix deprecation of set-output #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/set-output
branch
2 times, most recently
from
e199882
to
f471d63
Compare
consideRatio
force-pushed
the
pr/set-output
branch
from
f7305aa
to
e47ff3a
Compare
consideRatio
changed the title
manics
reviewed
Nov 14, 2022
consideRatio
force-pushed
the
pr/set-output
branch
from
85dcbbe
to
32884c2
Compare
consideRatio
commented
Nov 15, 2022
| echo "::set-output name=helm-version::$(helm version --short | sed 's/\([^+]*\).*/\1/')" | ||
| echo "kubeconfig=$HOME/.kube/config" >> $GITHUB_OUTPUT | ||
| echo "k3s-version=$(k3s --version | grep --max-count=1 'k3s' | sed 's/.*\(v[0-9][^ ]*\).*/\1/')" >> $GITHUB_OUTPUT | ||
| echo "k8s-version=$(k3s --version | grep --max-count=1 'k3s' | sed 's/.*\(v[0-9][^+]*\).*/\1/')" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
This emitted two lines, so a bugfix was introduced here to get only ome.
There was a problem hiding this comment.
K8s version is assumed from k3s version, so grep of k3s x2 is intended.
consideRatio
force-pushed
the
pr/set-output
branch
from
f4a8b1e
to
32884c2
Compare
manics
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-outputin GitHub workflows team-compass#579 for this repo.