Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used named parameters for calculateTags #94

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Used named parameters for calculateTags #94

merged 2 commits into from
Jun 4, 2021

Conversation

manics
Copy link
Member

@manics manics commented Jun 4, 2021

This will make the tests easier to manage in future if more parameters are added.

consideRatio
consideRatio approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also readability went up by a great amount! Very positive about this change!

@consideRatio consideRatio merged commit 7929d16 into jupyterhub:main Jun 4, 2021
@manics manics deleted the named-params branch June 4, 2021 20:15
manics added a commit to manics/action-major-minor-tag-calculator that referenced this pull request Jun 4, 2021
@manics
CHANGELOG: jupyterhub#94
998654d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manics @consideRatio