-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle disconnects & reconnects properly #80
Comments
This needs much better retry logic, with back-offs and status messages. But fundamentally, it does already work \o/ Fixes #80
I think the initial connection attempt maybe benefit from this also. I've seen the initial connection fail regularly when starting up locally, forcing a page reload - if it fails or not on the first attempt may be related to ping, and the fact that jupyter-server-proxy will finalize the handshake between client/proxy before proxy/server is even initialized (jupyterhub/jupyter-server-proxy#459) which makes initial traffic possibly disrupted. |
If the websocket disconnects now, the end user has to do a refresh of the page.
Once #77, #78, #79 get merged, we can detect these disconnects and try to reconnect.
The text was updated successfully, but these errors were encountered: